RTL CSS in uc_cart?

[bugfolder]

The uc_cart submodule contains CSS files for RTL:

• uc_cart_block-rtl.css
• uc_cart-rtl.css

But I don't see anywhere in the code that actually loads these.

Should we be doing something like this in all the places where we currently load the non-RTL files?

  $language = isset($GLOBALS['language']) ? $GLOBALS['language'] : language_default();
  // load -rtl CSS file if $language->direction == `rtl, otherwise load non-rtl CSS file

[bugfolder]

The above is not quite right. The *-rtl.css files are deltas, not replacements; i.e., they should be loaded in addition to the non-RTL css files.

And there are several modules that have *-rtl.css files, including:

• payment/uc_payment/uc_pament-rtl.css
• shipping/uc_quote/uc_quote-rtl.css
• uc_cart/css/uc_cart_block-rtl.css
• uc_cart/css/uc_cart-rtl.css
• uc_order/uc_order-rtl.css
• uc_product/uc_product-rtl.css
• uc_product_kit/uc_product_kit-rtl.css
• uc_store/uc_store-rtl.css

None of these files are loaded anywhere in Ubercart.

Typically, a CSS file is either included in the .info file, or loaded via something like this:

  backdrop_add_css(backdrop_get_path('module', 'uc_cart') . '/css/uc_cart.css');

Since we would need to check the language anywhere we're loading a file that has an RTL version, I suggest we create a utility routine that we can call to load a CSS file that automatically checks the language and, if appropriate, looks for a file with an -rtl suffix and loads that as well. Then we can go through all of Ubercart and replace backdrop_add_css() with our utility function.

[argiepiano]

@bugfolder, this sounds like a good plan to me.