search

backdrop / backdrop-issues

Issue tracker for Backdrop core.
145 stars 40 forks source link

[meta] Drupal 7 fix list #1 #132

Closed maxpearl closed 10 years ago

maxpearl commented 10 years ago

Here is the first list of drupal 7 fixes after the fork from the drupal 7 git history. The rest will be in separate tickets. These are reverse chronologically arranged. See also: #134 and #135 and #222

quicksketch commented 10 years ago

Thanks again @michellemurrain for putting all these together! I think considering the volume of patches, and their ease of porting to Backdrop, perhaps we should practice a policy of "no Github issue is required if it's a direct D7 port". In such cases, pull requests may be filed directly and if necessary point to this issue. We've already got a long, long Git history of Drupal.org issue numbers in our commit messages, I don't think it would be terrible to make exceptions for these D7 ports and reference the original Drupal.org issue instead of our own.

biolithic commented 10 years ago

open | #xx | 08bddd6 | Issue #1868206 by kiamlaluno: Fixed Word is repeated. -- refers to the overlay module which is no longer in Backdrop

maxpearl commented 10 years ago

Thanks! Yanked it.

biolithic commented 10 years ago

Michelle, I am going through this list right now. Thanks for doing this!

quicksketch commented 10 years ago

I've merged in the first batch of these from @biolithic in https://github.com/backdrop/backdrop/issues/105. Great work!!

quicksketch commented 10 years ago

I merged in the second batch in https://github.com/backdrop/backdrop/issues/111, thanks again @biolithic! In addition, I marked 12 additional issues N/A, as they apply to files/modules that don't exist in Backdrop.

quicksketch commented 10 years ago

Yay, @biolithic's PR at https://github.com/backdrop/backdrop/issues/164, closes another 39. Thanks!

quicksketch commented 10 years ago

I merged in @biolithic's PR at https://github.com/backdrop/backdrop/pull/176, which closes out another 51 issues. Looking good!

ronnienorwood commented 10 years ago

Thanks for the tweet. I got a full-time job a couple of weeks ago that does not involve drupal or backdrop so I won't be able to participate in backdrop thursday for the foreseeable future. I will try to contribute when I can and look forward to the initial release.

quicksketch commented 10 years ago

Hi @ronnienorwood! Congratulations on your new job! I hope it works out for you. ;)

Thanks for your help. :)

jenlampton commented 10 years ago

Okay, almost all the hard ones here are done. Removing my self as assignee, and moving the novice remove t() issues over here https://github.com/backdrop/backdrop-issues/issues/267. These are no longer release blockers because all these remove t() from tests issues can be done at any time.

The only issue we should keep an eye on is this one: https://github.com/backdrop/backdrop-issues/issues/268 Issue #1739986 by RobLoach, pwolanin, sun, Berdir, moshe weitzman, andypost, dcam: Fixed fallback in backdrop_get_hash_salt(), move it to bootstrap.inc, use instead of $GLOBALS['hash_salt']. It was committed to D7 but broke simpletest. We should wait for a fix on that issue on d.o and then apply the same fix for Backdrop.

quicksketch commented 10 years ago

Woo! We are DONE here. A few more difficult follow-ups marked by Jen above, but now that they have their own issues we're complete with this Meta. Nice job! This completes all 3 of our initial crossports from D7.