search

backdrop / backdrop-issues

Issue tracker for Backdrop core.
144 stars 39 forks source link

[META] icon cleanup in core #2814

Open jenlampton opened 7 years ago

jenlampton commented 7 years ago

There are several places in core where we have icons. I would like to see them treated consistently, with a file-naming convention that allows people to understand what they are at first glance.

We should replace any old icons with new, larger font-awesome equivalent versions as generated by http://fa2png.io. All icons are .pngs at 64px that we can size-down via CSS to look good on retina displays. Additionally, I would like to rename these files to include 1) the font-awesome name, 2) the color 3) the size. Note: These are based on what @wesruv did in his PR

Examples are as follows:

If we can use this issue to agree on a naming convention, we can use each of these sub-issues to do the cleanup:

opi commented 7 years ago

The <name>--<color>--<size>.png pattern is good. It reminds me the BEM with 2 modifier level.

jenlampton commented 7 years ago

Should we always include color and size, or do you think that if the icons were, say, black and 64px, they could be omitted? (see https://github.com/backdrop/backdrop-issues/issues/2802)

jenlampton commented 7 years ago

From chat:

always, I guess. Makes it easier to process in batch, with some command line stuff for example. And I don't know what the default is !

klonos commented 7 years ago

I think that we should always mention the same things in the filenames for all files, even the "default" ones. Reasons being a) not everyone knows what the "default" is b) the defaults might change from theme to theme and c) consistency.

jenlampton commented 7 years ago

Sounds good. Thanks for the feedback :) I've implemented this naming convention for the newest icons in https://github.com/backdrop/backdrop-issues/issues/1178