search

backstage / charts

Backstage Helm Charts
Apache License 2.0
143 stars 82 forks source link

bug: extraDeploy is defined as a value under values.yaml but there is no implementation #76

Closed cmartell-at-ocp closed 1 year ago

cmartell-at-ocp commented 1 year ago

Hello,

extraDeploy is defined under values.yaml but there is no implementation around it: https://github.com/backstage/charts/blob/main/charts/backstage/values.yaml#L38-L39

Seems like this helm chart is following Bitnami's chart structure (together with Bitnami's common), so it would be a matter of creating a new template file as such: https://github.com/bitnami/charts/blob/main/bitnami/argo-cd/templates/extra-list.yaml.

tumido commented 1 year ago

Resolved via #89

(Note to self: I should read through all the issues before claiming I've discovered a bug 😄 )

Thank you @cmartell-at-ocp for noticing this! 👍

cmartell-at-ocp commented 1 year ago

Hah, no worries! Thank you for fixing this!