backstage / community-plugins

Community plugins for Backstage
Apache License 2.0
156 stars 186 forks source link

🐛 Bug Report: EntityTechInsightsScorecardCard broken style #1353

Open LegendSebastianoL opened 1 month ago

LegendSebastianoL commented 1 month ago

📜 Description

After updating Backstage from 1.29 to 1.31 I have this style in the EntityTechInsightsScorecardCard component image

The p and the icon should live on the same line, the text should not go under the icon.

👍 Expected behavior

The wrapper for the p and the icon should be flex and display the text and the icon properly, like before the update.

This is a screenshot of version 1.29 image

👎 Actual Behavior with Screenshots

as you can see in the 1st screenshot, the text goes under the icon.

👟 Reproduction steps

downgrade backstage from 1.31 to 1.29 and you will see the differences

📃 Provide the context for the Bug.

No response

🖥️ Your Environment

No response

👀 Have you spent some time to check if this bug has been raised before?

🏢 Have you read the Code of Conduct?

Are you willing to submit PR?

None

vinzscam commented 2 weeks ago

@LegendSebastianoL are you using a custom theme? If yes, could you check whether you are experiencing the same issue when using the default theme?

LegendSebastianoL commented 1 week ago

@vinzscam 👋 yes, I'm using a custom theme.

import { UnifiedThemeProvider, themes } from '@backstage/theme';

const app = createApp({
  apis,
  themes: [
    {
      id: 'customTheme',
      title: 'Custom Theme',
      variant: 'dark',
      Provider: ({ children }) => (
        <UnifiedThemeProvider theme={themes.dark} children={children} />
      ),
    },
  ],

I just tried to use the default themes.dark and I got the same result. image