search

badger707 / m920q-dual-NVME

Lenovo M920Q dual NVME, conversion to M920X.
140 stars 17 forks source link

Just fixed a few typos #1

Closed KineticMaintenance closed 1 year ago

KineticMaintenance commented 1 year ago

Hey, saw a few typos, so have made some changes.

Noticed the capacitors to the right of the SATA1 connector (C377-C379) were mislabeled, along with R150 (named R105)

badger707 commented 1 year ago

Hey, thanks for pull request and thanks for spotting spelling/grammar and labeling typos. Disagree with few 3 items:

  1. row118 -- Caps count at the side of NVME edge connector pads -- there is only 4 caps actually on power rail, not 5, and highlighted RC27 is a resistor which should not be touched. I just left RC27 highlighted in early versions of pictures when uploading initially, I'll update picture and will remove reference.
  2. row120 -- RC26 is "no connect" because PEDET2 must be in HIGH state. We might revisit this part when we'll have more chipsets tested.
  3. row144&145 -- Caps C378-C377-C379 --> top down order on the picture board is correct. While soldering, C379 (bottom cap) was too close to SATA connector for me, so I removed C377 (middle cap) and moved C379 (bottom cap) up by one step to the middle spot to keep it away from SATA port. Therefore picture represent the order how I have it soldered. Its just caps, it does not matter in which order they go,

Other than that - happy to merger if you'll do corrections on your side. I'm not good at Git stuff, still learning how this all works, so sorry in advance. Closing now, but please re-submit.

badger707 commented 1 year ago

Closing as no response received.