search

badges / shields

Concise, consistent, and legible badges in SVG and raster format
https://shields.io
Creative Commons Zero v1.0 Universal
23.46k stars 5.49k forks source link

Badge Request: GitHub Check ignore pending builds #10221

Open oliviertassinari opened 3 months ago

oliviertassinari commented 3 months ago

📋 Description

I have migrated to https://shields.io/badges/git-hub-branch-status, but compared to the CircleCI badge, it shows the latest build status: SCR-20240602-qbse

while the CircleCI badge shows the latest non-pending build status. CircleCI seems the expected behavior. The use case is to be able to, with a glance, see if there is something to be worried about (broken CI branch).

It would be great if we could fix this.

PyvesB commented 3 months ago

Hello @oliviertassinari 👋🏻

Our GitHub branch status badge directly forwards the status returned by the GitHub API (see code) . I believe that this is the same status as the one shown in the GitHub UI (green check, red cross, orange dot). In addition to changing a historical behaviour which users seem happy with (this badge was implemented all the way back in #5973), I feel that introducing an inconsistency and having the badge show something different than the GitHub UI would be misleading and confusing.

oliviertassinari commented 3 months ago

I feel that introducing an inconsistency and having the badge show something different than the GitHub UI would be misleading and confusing.

@PyvesB I agree, these are fundamentally two different concepts.

The core of this issue is to request the introduction of another concept that I would expect to match the most common use case for this badge.