search

badlogic / skyview

Thread reader for Bluesky
MIT License
35 stars 3 forks source link

UTF-8 aware rich text #7

Closed intrnl closed 1 year ago

intrnl commented 1 year ago

Bluesky's rich text works with UTF-8 indices for indicating which part of the text is part of a feature, the code currently in use in Skyview currently ignores this fact and uses the indices to slice text in UTF-16 (JavaScript) instead.

my recommendation would be to follow the example I had provided here

this makes sure that non-Latin posts are being rendered correctly

intrnl commented 1 year ago

Closing since it's now relying on the RichText API from @atproto/api

badlogic commented 1 year ago

Sorry didn't check the tracker before inplementing it :)

On Tue, Oct 17, 2023, 22:37 Prana Adiwira @.***> wrote:

Closed #7 https://github.com/badlogic/skyview/issues/7 as completed.

— Reply to this email directly, view it on GitHub https://github.com/badlogic/skyview/issues/7#event-10683510322, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD5QBGEHJD5GLQIXYYEGLTX73T63AVCNFSM6AAAAAA6D7QIQSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQGY4DGNJRGAZTEMQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

intrnl commented 1 year ago

It's all good, so long as the posts are being rendered correctly :)