search

badoo / liveprof-ui

An aggregator and web interface for Live Profiler
http://liveprof.org/
MIT License
126 stars 19 forks source link

Fixed getting lastInsertId for mysql/pgsql #3

Closed lebedevsky closed 5 years ago

lebedevsky commented 5 years ago

Method: src/Badoo/LiveProfilerUI/DB/Storage.php::getLastInsertId() return 0 with mysql/pgsql driver.

You need to get getLastInsertId in transaction before commit (src/Badoo/LiveProfilerUI/DB/Storage.php:313). After commit it will be return 0.

codecov-io commented 5 years ago

Codecov Report

Merging #3 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #3      +/-   ##
============================================
+ Coverage     87.75%   87.77%   +0.01%     
- Complexity      707      708       +1     
============================================
  Files            44       44              
  Lines          2173     2176       +3     
============================================
+ Hits           1907     1910       +3     
  Misses          266      266
Impacted Files Coverage Δ Complexity Δ
src/Badoo/LiveProfilerUI/DB/Storage.php 93.93% <100%> (+0.09%) 68 <1> (+1) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a40a3f4...a94036c. Read the comment docs.