search

badoo / liveprof-ui

An aggregator and web interface for Live Profiler
http://liveprof.org/
MIT License
126 stars 19 forks source link

fix LiveProf-UI aggregator saveMethodData behavior #6

Closed Slach closed 5 years ago

Slach commented 5 years ago

for xhprof_sampling_data results with mysql_query#extra_long_string_with_spaces saveMethodData cant resolve function name from $map when this exists

should i provide additional test for coverage this corner case?

codecov-io commented 5 years ago

Codecov Report

Merging #6 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #6   +/-   ##
=========================================
  Coverage     88.64%   88.64%           
  Complexity      801      801           
=========================================
  Files            45       45           
  Lines          2430     2430           
=========================================
  Hits           2154     2154           
  Misses          276      276
Impacted Files Coverage Δ Complexity Δ
src/Badoo/LiveProfilerUI/Aggregator.php 94.49% <100%> (ø) 88 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 297fb57...2a871f6. Read the comment docs.

shagtv commented 5 years ago

Thank you for contributing!