baggepinnen / FluxOptTools.jl

Use Optim to train Flux models and visualize loss landscapes
MIT License
59 stars 4 forks source link

Fix for #10 #13

Closed pakk-minidose closed 2 years ago

pakk-minidose commented 2 years ago

Closes #10 Although I have not tried to reproduce the issue, I think that it should also close #9.

Basically, the custom copyto! was replaced by Zygote's built in functions (plus some other changes).

If this PR is approved, documentation on the front page will need a change.

codecov[bot] commented 2 years ago

Codecov Report

Merging #13 (f5bbe96) into master (f88409a) will decrease coverage by 1.17%. The diff coverage is 100.00%.

:exclamation: Current head f5bbe96 differs from pull request most recent head c95bc66. Consider uploading reports for the commit c95bc66 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage   96.58%   95.40%   -1.18%     
==========================================
  Files           2        2              
  Lines         117       87      -30     
==========================================
- Hits          113       83      -30     
  Misses          4        4              
Flag Coverage Δ
unittests 95.40% <100.00%> (-1.18%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/FluxOptTools.jl 90.47% <100.00%> (-3.97%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f88409a...c95bc66. Read the comment docs.

pakk-minidose commented 2 years ago

The codecov seems to have indirectly decreased. Is it a reason for the failing check?

baggepinnen commented 2 years ago

The codecov is fine, a lot of hits were removed which decreased the percentage but that's no problem. If we update the description in the Readme as well this will be good to merge?

baggepinnen commented 2 years ago

Cool! Thanks for your contribution :)

pakk-minidose commented 2 years ago

I was happy to help ;-)