bahmutov / cypress-svelte-unit-test

Unit testing Svelte components in Cypress E2E test runner
162 stars 21 forks source link

Chore: Improve html template check #305

Open royalrex opened 1 year ago

royalrex commented 1 year ago

This PR simplifies the logic around template usage.

It adds a more strict check to html property of styleOptions and disregards empty strings.

The check that disregards empty strings as a valid value can be discussed. I believe it adds to convenience to disregard empty strings as a value, but it can also be a bit misleading as not error will be shown warning about setting that to empty.

This fix came when I was testing my other PR: Fix: properly destroy components after test case (#304)