Closed tunnckoCore closed 7 years ago
Mm nope. Sorry, but it obviously is some problem with semantic-release
, probably. https://github.com/tunnckoCore/koa-better-serve/commit/dbf5830737ac5063aea0e26b8d1550815c7dcac6
That's impossible. :scream:
Okey, very sorry. Probably my fault, but it's some absurd, for me, to be possible to release major only with type major
(without using simple-commit-message), but it seems that way by just using raw git commit
.
Finally, released.
Can't think for some more meaningful title, sorry.
In last hour and two, i'm updating one of my repos, so i included
semantic-release
,simple-commit-message
andgithub-post-release
.I pushed a
fix
type commit withYes
answer ofIs this major breaking change?
question.And from the console
And as you see, semantic release published patch version, instead of major. Initially, it was absolutely shock for me, because in first look everything looks okey. But when you look more carefully you may see that the body's
BREAKING CHANGE
does not have color (:
), which i believe caused semantic release to not understand really that this is major change.For first time i'm bumping major with this package, instead of
commitizen
. Probably you too? Because if i remember correctly the important thing is that it must beBREAKING CHANGE:
in the body. It's not important forsemantic-release
and (previously used by me)standard-version
-- adding it to the title is just a stylistic thing for the users to see it more easy.All this caused me a bit headache, because need to back to the prev commit, delete release/tag and unpublish that version from npm.