search

bakwc / PySyncObj

A library for replicating your python class between multiple servers, based on raft protocol
MIT License
706 stars 113 forks source link

Wrong log output to stdout. May break apps using library. #153

Closed Kishi85 closed 3 years ago

Kishi85 commented 3 years ago

commit fd40b739d6cf12115c103cfb927a2831f673e82d added a print() statement to the disconnect function that always outputs "Disconnect request" to stdout. This can break apps using pysyncobj due to excessive log output in interactive use-cases.

Example: Patroni's edit-config feature spawns vi to edit the config values, which gets totally plastered by above message while the config is edited, making the editing almost impossible due to not being able to see what is actually done.

I propose to change the output from print(...) to using python logging (using level DEBUG?) as it is already used in syncobj.py and this seems to be an oversight from implementing/testing.

bakwc commented 3 years ago

Oh, sorry, that was not intended to go to production. Removed that print, updated in pip, please update version to 0.3.10. I will add a unit-test to avoid adding prints in the future, #154

Kishi85 commented 3 years ago

Thank you, that fixes the issue!