search

balchua / microk8s-actions

Bootstrap MicroK8s with Github Actions
34 stars 9 forks source link

Failing shell commands don't cause step to fail #5

Closed knkski closed 3 years ago

knkski commented 3 years ago

If I have this in my workflow:

    - uses: balchua/microk8s-actions@v0.2.1
      with:
        channel: 'nonexistent'

I will get this error message in stdout: error: snap "microk8s" is not available on nonexistent/stable but is available ..., but that doesn't cause the step to fail. Instead, it proceeds to wait for the API server to come up, which it never will because MicroK8s didn't get installed.

It looks like this needs to be run:

set('-e');

It would also be nice if this got set:

set('-v');

As it would be useful for debugging purposes

balchua commented 3 years ago

Thanks for creating the issue @knkski. I've added the fail on exception and enable verbose output.