search

baldram / ESP_VS1053_Library

A library for VS1053 MP3 Codec Breakout adapted for Espressif ESP8266 and ESP32 boards.
https://platformio.org/lib/show/1744/ESP_VS1053_Library
GNU General Public License v3.0
114 stars 36 forks source link

Make write_register public. #65

Closed CelliesProjects closed 3 years ago

CelliesProjects commented 3 years ago

Make write_register public. This makes it more easy to load the patches from http://www.vlsi.fi/en/support/software/vs10xxpatches.html

baldram commented 3 years ago

Thanks for contribution @CelliesProjects! It's merged. Are you willing to test a snapshot from Github directly? Supported schemes: https://docs.platformio.org/en/latest/core/userguide/lib/cmd_install.html#version-control

We could make a release when next features are added.

CelliesProjects commented 3 years ago

@baldram Thanks for the merge.

Thanks for contribution @CelliesProjects! It's merged. Are you willing to test a snapshot from Github directly? Supported schemes: https://docs.platformio.org/en/latest/core/userguide/lib/cmd_install.html#version-control

We could make a release when next features are added.

I use the Arduino IDE.

baldram commented 3 years ago

@CelliesProjects

I use the Arduino IDE.

Ok, I've never used it, so I understand is ok as is now.

Not sure you noticed an answer in a closed comment. I opened a discussion as you suggested, here: #66. Please feel free to correct me if I mixed-up something. Would be super cool if about another PR. I think we might consider adding a universal loadUserCode method as anyway it will be needed. Whatever will be a result of discussion.