balena-os / jetson-flash

This tool allows users to flash BalenaOS on Jetson supported devices
Apache License 2.0
64 stars 16 forks source link

Node v20 warning for non-Docker install #179

Open kb2ma opened 5 days ago

kb2ma commented 5 days ago

When running npm install with node lts/iron (v20.17.0), the install reports that the drivelist package does not support that node version, like below. I see jetson-flash package.json specifies only node>=16. So, I dropped the node version down to lts/hydrogen (v18.20.4) to remove the warning.

[2024-09-23 -- The statement below from the original post of this issue is wrong. Drivelist up to v11.1.1 supports node >=16 < 19. Drivelist v11.2.0 supports node >=16, and drivelist v12.0.0 supports node >=18 -- so it still supports node 18. So the issue is that my jetson-flash build used drivelist v11.1.0. The problem is more about package resolution from jetson-flash -- at least when I tested. Let me recreate the test.]


The drivelist package dropped support for node v18 in its v12.0.0. Time to update nodelist to latest (v12.0.2) and update jetson-flash node version requirement to >=20 as well?

$ npm install
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: 'drivelist@11.1.0',
npm warn EBADENGINE   required: { node: '>=16 < 19' },
npm warn EBADENGINE   current: { node: 'v20.17.0', npm: '10.8.2' }
npm warn EBADENGINE }
kb2ma commented 3 days ago

I can confirm that use of node v20 generates the warning on current master. The chain of package dependencies is:

Next step is to experiment with advancing the drivelist version in the etcher-sdk dependencies.