baliga-lab / cmonkey2

Python port of cMonkey, a machine-learning based method for clustering
GNU Lesser General Public License v3.0
26 stars 16 forks source link

Minor bug in stringdb.py #71

Closed izzi-13 closed 7 years ago

izzi-13 commented 7 years ago

Hi, In line 99 of stringdb.py, I think 'total_nodes += 1' should be tabbed over (so it's within the 'if not node in keep_node:' block), as currently it counts each gene more than once. (This means that even if every node gets excluded, the output suggests that some have been included, which isn't helpful when trying to work out where things have gone wrong!) Thanks! Isabel

izzi-13 commented 7 years ago

Have now submitted a pull request.

weiju commented 7 years ago

Hi, thanks for reporting the issue and sending the pull request. I have now merged your changes