balintlaczko / MGT-python

Musical Gestures Toolbox for Python
https://www.uio.no/ritmo/english/research/labs/fourms/downloads/software/musicalgesturestoolbox/mgt-python/index.html
GNU General Public License v3.0
1 stars 0 forks source link

Object should 'forget' (delete?) all in-between videos, and update self.filename to the latest #15

Closed balintlaczko closed 4 years ago

balintlaczko commented 4 years ago

If we want to trim, skip frames, crop, etc there will be as many videos created in the folder as steps in the process, which is not too elegant... Also, since a lot of methods require a filename, this puts the responsibility on the user that s/he should know the exact order of execution to guess the correct filename for a certain method (for ex. 'dance_trim_skip.avi' and NOT 'dance_skip_trim.avi') or just look it up every time (which s/he will probably end up doing). Responsibility is nice, but it would also be nice to just keep the name str of the last step as the current self.filename and be able to work with that if we just call for ex. show() or history() or motionhistory() without giving a filename. (And if we pass a filename, we will work with that, of course, instead of self.filename.) There can also be a keep_all=0 param for the class, so if the user really wants to keep every step, s/he can.

balintlaczko commented 4 years ago

Okay, so it's more clear now, I actually mixed two different issues, one is to only keep the last video file from the videoreader() and not all steps in between (I will use this issue for that), the other is to be able to call history(), motionvideo(), motionhistory() etc on the latest filename without having to provide one - but of course, only if we choose to. This will be moved to its own issue.

balintlaczko commented 4 years ago

Implemented. Added keep_all=False param, if True, all the videos are kept as before.