Open MaryamZi opened 11 months ago
Description: With https://github.com/ballerina-platform/ballerina-lang/pull/41049, we are adding support for error typed binding patterns in the on-fail clause.
With this, NodeFactory.createOnFailClauseNode changes from
NodeFactory.createOnFailClauseNode
public static OnFailClauseNode createOnFailClauseNode( Token onKeyword, Token failKeyword, TypeDescriptorNode typeDescriptor, IdentifierToken failErrorName, BlockStatementNode blockStatement) {
to
public static OnFailClauseNode createOnFailClauseNode( Token onKeyword, Token failKeyword, TypedBindingPatternNode typedBindingPattern, BlockStatementNode blockStatement) {
We need to update usage in https://github.com/ballerina-platform/graphql-tools/blob/main/graphql-code-generator/src/main/java/io/ballerina/graphql/generator/client/generator/ballerina/FunctionBodyGenerator.java#L281 and pass a typed binding pattern (similar to https://github.com/ballerina-platform/graphql-tools/blob/main/graphql-code-generator/src/main/java/io/ballerina/graphql/generator/client/generator/ballerina/FunctionBodyGenerator.java#L401) instead of the type descriptor and identifier separately.
Timestamped version with the change - 2201.8.0-20230720-214400-9518f4f5
We are planning on adding this to update 8.
Keeping this on-hold, as the related language side changes are expected to be shipped with U9.
Description: With https://github.com/ballerina-platform/ballerina-lang/pull/41049, we are adding support for error typed binding patterns in the on-fail clause.
With this,
NodeFactory.createOnFailClauseNode
changes fromto
We need to update usage in https://github.com/ballerina-platform/graphql-tools/blob/main/graphql-code-generator/src/main/java/io/ballerina/graphql/generator/client/generator/ballerina/FunctionBodyGenerator.java#L281 and pass a typed binding pattern (similar to https://github.com/ballerina-platform/graphql-tools/blob/main/graphql-code-generator/src/main/java/io/ballerina/graphql/generator/client/generator/ballerina/FunctionBodyGenerator.java#L401) instead of the type descriptor and identifier separately.
Timestamped version with the change - 2201.8.0-20230720-214400-9518f4f5
We are planning on adding this to update 8.