Open danfox01 opened 4 years ago
@danfox01 so looking at this I noticed that when the screen re-loads and jumps to the top it shows Username: [None]. It looks like we can add to that the error message you have listed above in place of none which really doesn't make sense. Scrolling down to where you can change username its all highlighted red to signify there's a problem so that might be a temporary solution and would be quick since it doesn't seem like we have an alert section setup on this page.
However is there a test account in ils-test I can use to see if these changes work? Using that barcode in ils got me yelled at.
@tmccoy529 - I sent you the credentials for ilstest via teams and it has been added to the Web Services keepass
@jdomasky this is ready for a look. Im not sure the best place to put the error message so I just placed it at the top as Dan had suggested since it reloads to the top but it might need some tweaking.
Page to move: repos\Polaris Skin for BCPL\patronaccount\default.aspx
@tmccoy529 Thanks! I'll review this in Polaris dev either today or early next week.
FYI @hburnopp @mcorasan @theilman7 @tthbcmd
@tmccoy529 I've confirmed the solution in dev and I recommend it for deployment to prod with a suggested change to the layout:
The error message seems to be indented 1.25em at the mobile breakpoint. However, at all other breakpoints, the message is displayed flush with the left DIV boundary, as shown in the screenshot of the tablet breakpoint above.
Recommendation: Apply the 1.25em indent at all breakpoints.
FYI @hburnopp @mcorasan @theilman7 @tthbcmd
@jdomasky I have added the 1.25em to all break points. This is ready for a look.
files to move: repos\Polaris Skin for BCPL\custom\themes\bcpl-powerpac\site.css
@tmccoy529 I reviewed the CSS change in dev and the error message is now displayed consistently at all breakpoints. I recommend this solution for deployment to production.
FYI @hburnopp @mcorasan @theilman7
Describe the bug In Polaris, users who try to choose a username that's already taken should get an error message. This is not currently happening. Instead the page just reloads with no feedback explaining why.
There is an error message defined in Polaris for this case, but we're not showing it in our customized version.
To Reproduce (Provided by Karrie Armetta)
Expected behavior When the steps above are completed, the user should receive an error message. The exact message is already defined in Polaris as PACML_CHANGEUSERNAME_1307 -- ideally, we would just display this string when the user clicks save in the process above.
Affected device and browser:
Additional context I was unable to find a similar inline error message that we could replicate the styling on. When it comes time to design the error layout and figure out where it goes, here are some guidelines: