search

balvig / utensils

Rspec stuff we use over and over again
MIT License
11 stars 9 forks source link

Remove capybara-screenshot utensils #13

Closed sikachu closed 5 years ago

sikachu commented 5 years ago

This should allow developers to view all of the test failures screenshots if they save them as an artifact on the CI server, instead of having the file get overridden because it has the same filename.

Also, this will restore the path where the screenshot will be save, so it can be overridden by the underlying apps if needed.

Update: After some further internal discussion, we decided to remove this utensils altogether. I've updated the PR to reflect this.

sikachu commented 5 years ago

@balvig would you mind taking a look at this and let me know what you think?