search

banditoth / MAUI.Packages

A toolkit for .NET MAUI 🏝, containing useful stuff to ease development for MAUI applications.
MIT License
39 stars 3 forks source link

Update NET8 Compatibility #16

Open agustinbishel opened 4 months ago

agustinbishel commented 4 months ago

So... here we are again, haha. I fixed this project too. I haven't tested it on Windows, but it works fine on iOS and Android. I really want to thank you for your time. This is not critical for me, so whenever you have time to review it, it would be nice.

StephanArnas commented 4 months ago

I agreed with the PR of @agustinbishel. I have a project referencing .net8.0 project, like Infrastructure and I can't reference banditoth.MAUI.Multilanguage on version 1.0.6 in this project because TargetFrameworks is not compatible with net8.0, I need ITranslator interface in Infrastructure project. Thank you, Stephan.

banditoth commented 4 months ago

I agreed with the PR of @agustinbishel. I have a project referencing .net8.0 project, like Infrastructure and I can't reference banditoth.MAUI.Multilanguage on version 1.0.6 in this project because TargetFrameworks is not compatible with net8.0, I need ITranslator interface in Infrastructure project. Thank you, Stephan.

Hey @StephanArnas Please check again, the 1.0.6 version should be working fine with .net8 :)

image

This pull request is for DeviceId, which I will verify sooner or later whether its working or not :)

StephanArnas commented 4 months ago

Thanks for your answer. Sorry I was not clear in my request :) The version 1.0.5 targeted frameworks net8.0 and net7.0, which means I was able to reference the project in class library project in my solution.

Capture d’écran 2024-07-31 à 14 50 43

The version 1.0.6 do not target framework net8.0, so I can only reference it into my MAUI project.

Capture d’écran 2024-07-31 à 14 50 52

My issue is I need ITranslator in the class library project (like Infrastructure), maybe you could consider having another package banditoth.MAUI.Multilanguage.Abstracts or targeting net8.0 ?

Capture d’écran 2024-07-31 à 14 58 26

I hope my answer bring you more context on my request, if you try to install banditoth.MAUI.Multilanguage on class libray project, you will have this error :

Package banditoth.MAUI.Multilanguage 1.0.6 is not compatible with net8.0 (.NETCoreApp,Version=v8.0). Package banditoth.MAUI.Multilanguage 1.0.6 supports:

StephanArnas commented 4 months ago

Oh yes, I read too fast the commit, I thought you were adding net8.0 to banditoth.MAUI.Multilanguage but indeed, it's for DeviceId, should I open a bug to reference it ?