banister / method_source

return the sourcecode for a method
MIT License
361 stars 43 forks source link

fix gemspec version #48

Closed dai-vdr closed 7 years ago

dai-vdr commented 7 years ago

T/O

banister commented 7 years ago

Thansk,

But is it possible to just require the version inside the gemspec and use that instead?

We do something like that here: https://github.com/pry/pry/blob/master/pry.gemspec#L2-L6

However when i do that in method_source i notice that i end up with constant redefinition warnings when running pry in method_source. Would you be able to figure out what's going on here? 👍

dai-vdr commented 7 years ago

Your approach is better than mine. But i did not get constant redefinition warnings with running pry...

banister commented 7 years ago

@dai-vdr turns out we have a rake task that does this automatically: rake gemspec so i just ran that and then committed it

dai-vdr commented 7 years ago

thanks! 👍