search

banister / method_source

return the sourcecode for a method
MIT License
361 stars 43 forks source link

More closely match MIT License text verbatim #61

Closed jasonkarns closed 4 years ago

jasonkarns commented 4 years ago

Tweak the license such that tooling (in particular, licensee) recognizes the LICENSE file as MIT.

Before:

$ /usr/local/share/gem/bin/licensee 
License:        NOASSERTION
Matched files:  LICENSE, README.markdown, method_source.gemspec
LICENSE:
  Content hash:  bfd1a6d003c3210704bb2025ee95bfc059adcd4d
  License:       NOASSERTION

After:

$ /usr/local/share/gem/bin/licensee 
License:        MIT
Matched files:  LICENSE, README.markdown, method_source.gemspec
LICENSE:
  Content hash:  d64f3bb4282a97b37454b5bb96a8a264a3363dc3
  Attribution:   Copyright (c) 2011 John Mair (banisterfiend)
  Confidence:    100.00%
  Matcher:       Licensee::Matchers::Exact
  License:       MIT
kyrylo commented 4 years ago

It's a minor change and I have no problems merging it but isn't it weird that we need to adjust for a tool that detects licenses? 🙃 I thought the whole purpose was to detect all possible styles and report the licence.

jasonkarns commented 4 years ago

Agree. I think it's because the MIT license text is so short, any deviation pushes the difference over the 5% threshold. It's also possible that differences at the beginning are weighted more heavily? 🤷‍♂

Thanks for merging, regardless. 😸

jasonkarns commented 4 years ago

I probably should have mentioned that with this change, the LICENSE file is virtually identical to the MIT text from https://choosealicense.com. The only differences are: