banji-project / ring-issues

Old issues before it was moved to kde.org
0 stars 0 forks source link

option to close / dont show again the first time "search for participant" overlay, even if no one has been added #51

Open star-buck opened 6 years ago

star-buck commented 6 years ago

screenshot_20180612_112553

Elv13 commented 6 years ago

the feature itself is ready for testing, the following side effects are being addressed

* Make sure the normal UX behave correctly when there is no selected individual
* Disable everything that cannot be clicked to avoid confusion
* Add a new user facing message when there is nothing selected
* Do not show the contact and bookmark sorting widget when empty
* Do not allow the callview to be used without an account
* Disable the contact editor fields
* Do not display the scrollbar when there is nothing
* Make sure the GUI doesn't try to fallback on its own profile due to the lack of other elements to pick as fallback

Previously, the welcome message shielded the whole GUI from being used when it's in an invalid state, but now "null" has to be handled in more places. Nothing serious, just many little changes. It's mostly done, along with more bug fixes reported by the RC testers. I will mark this issue green once all elements in the list above are well tested.