fix #18 Added Component API support to react-emoji

banyan / react-emoji

An emoji mixin for React

MIT License

197 stars 40 forks source link

fix #18 Added Component API support to react-emoji #19

Open vinnymac opened 8 years ago

vinnymac commented 8 years ago

Tests are passing, but I haven't yet finished any new ones. Please feel free to comment and review :)

I also added some new examples to show how to use the new component.

This will be a breaking change for previous users because of the export changes.

banyan commented 8 years ago

This will be a breaking change for previous users because of the export changes.

I'm happy if we don't have the breaking changes. Let me just consider.

reimertz commented 8 years ago

I have been using this for 1 week now, works really well.

Thanks @vinnymac !

vinnymac commented 8 years ago

@banyan I can remove the breaking change and just let users export a component via destructuring. Not certain what it would be called if we do that though. Using the word component is too vague.

@reimertz you are welcome, glad someone is using it!