banzaicloud / banzai-charts

Curated list of Banzai Cloud Helm charts used by the Pipeline Platform
Apache License 2.0
368 stars 284 forks source link

Fix: metric-server chart rbac #1253

Open kobejn-jb opened 3 years ago

kobejn-jb commented 3 years ago

Replaced .Values.rbac.create with .Values.rbac.enabled used in IF statements in several templates to match default Values and other templates. Changed README.md to match changes and describe proper usage of a chart

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
Related tickets no related ticket
License Apache 2.0

What's in this PR?

There is en issue with deploying metrics-server chart with default values, in some templates value rbac.enabled is used but in others rbac.create. This is confusing and rbac,create is not in default values. This PR cleans that up by making all templates use rbac.enabled.

Why?

Paragraph above explains it

Checklist