search

banzaicloud / banzai-charts

Curated list of Banzai Cloud Helm charts used by the Pipeline Platform
Apache License 2.0
367 stars 278 forks source link

Upgrade prometheus-operator-standalone to 0.63.0 #1337

Closed nishantapatil3 closed 1 year ago

nishantapatil3 commented 1 year ago
Q A
Bug fix? no
New feature? yes (prometheus standalone operator 0.63.0)
API breaks? no
Deprecations? no
Related tickets fixes - prometheus operator is unable to reconcile prometheus CR
License Apache 2.0

What's in this PR?

  1. Upgrade prometheus-operator-standalone crds to 0.63.0 version taken from kube-prometheus-stack
  2. Add additional clusterrole permissions to allow prometheus-operator to run on RHOS cluster

Why?

Fixes RHOS cluster deployment where we saw prometheus operator is unable to reconcile prometheus CR due to permissions issues in updating prometheus/status field

Checklist

Testing

On RHOS - 4.11

❯ kubectl config current-context
default/api-nispatil-2-24-4pq0-p1-openshiftapps-com:6443/cluster-admin
❯ k get deployments.apps -n smm-system smm-prometheus-operator -o wide
NAME                      READY   UP-TO-DATE   AVAILABLE   AGE   CONTAINERS                         IMAGES                                                                                              SELECTOR
smm-prometheus-operator   1/1     1            1           13h   smm-prometheus-operator,k8sproxy   quay.io/prometheus-operator/prometheus-operator:v0.63.0,registry.eticloud.io/smm/k8s-proxy:v0.0.9   app=smm-prometheus-operator,app.kubernetes.io/component=application,app.kubernetes.io/instance=smm-smm-prometheus-operator
❯

On k8s 1.24

❯ kubectl config current-context
nispatil-eks
❯ k get deployments.apps -n smm-system smm-prometheus-operator -o wide
NAME                      READY   UP-TO-DATE   AVAILABLE   AGE     CONTAINERS                         IMAGES                                                                                              SELECTOR
smm-prometheus-operator   1/1     1            1           4d22h   smm-prometheus-operator,k8sproxy   quay.io/prometheus-operator/prometheus-operator:v0.63.0,registry.eticloud.io/smm/k8s-proxy:v0.0.9   app=smm-prometheus-operator,app.kubernetes.io/component=application,app.kubernetes.io/instance=smm-smm-prometheus-operator
❯
nishantapatil3 commented 1 year ago

Thanks for the review and approval @tkircsi @pregnor