baoyachi / shadow-rs

A build-time information stored in your rust project.(binary,lib,cdylib,dylib)
https://docs.rs/shadow-rs
MIT License
444 stars 40 forks source link

shadow-rs: Fix linter on generated code #124

Closed sameo closed 1 year ago

sameo commented 1 year ago

The generated print_built_in() function triggers uninlined_format_args linter warning. See https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args

With that fix, it generates "\tprintln!("FOO: {FOO}");\n" code strings.

Signed-off-by: Samuel Ortiz sameo@rivosinc.com

baoyachi commented 1 year ago

@sameo Wow, your speed is so fast, I am going to submit it, you have already changed it.

It's same as #125

baoyachi commented 1 year ago

Thx again. @sameo

sameo commented 1 year ago

@sameo Wow, your speed is so fast, I am going to submit it, you have already changed it.

It's same as #125

haha :) I was 2 minutes faster ;-) Feel free to take whatever PR you prefer, fine with me.