Closed sholderbach closed 10 months ago
The fix for #141 introduces a problem for folks using an older rust toolchain. Clippy will complain about the unknown lint:
error: unknown lint: `clippy::needless_raw_string_hashes` Error: --> /home/runner/work/nushell/nushell/target/debug/build/nu-cmd-lang-05d8af32cd96fda8/out/shadow.rs:12:9 | 12 | #[allow(clippy::needless_raw_string_hashes)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `-D unknown-lints` implied by `-D warnings`
https://github.com/nushell/nushell/actions/runs/6293295044/job/17083630612?pr=10495
Using 1.70.0 in the rust-toolchain.toml: https://github.com/nushell/nushell/blob/d2f513da36fe3e8b2b60584e28deaa2c4253f666/rust-toolchain.toml#L19
1.70.0
rust-toolchain.toml
Maybe this can be suppressed by allowing unknown-lints for the file?
unknown-lints
@sholderbach new version published, please use:
shadow-rs = "0.24.1"
Awesome! Thanks, good call with the general allow().
allow()
The fix for #141 introduces a problem for folks using an older rust toolchain. Clippy will complain about the unknown lint:
https://github.com/nushell/nushell/actions/runs/6293295044/job/17083630612?pr=10495
Using
1.70.0
in therust-toolchain.toml
: https://github.com/nushell/nushell/blob/d2f513da36fe3e8b2b60584e28deaa2c4253f666/rust-toolchain.toml#L19Maybe this can be suppressed by allowing
unknown-lints
for the file?