1.12.1 support. - Githubissues

barneygale / quarry

Python library that implements the Minecraft network protocol and data types

Other

533 stars 74 forks source link

1.12.1 support. #38

Closed ocelotpotpie closed 7 years ago

ocelotpotpie commented 7 years ago

To be honest, I'm not 100% sure if I'm doing this correctly, but this appears to add support for the 1.12.1 protocol.

williammck commented 7 years ago

Looks great, just needs a few changes:

(referencing http://wiki.vg/Protocol)

prepare_crafting_grid (upstream, 0x01) has been replaced by craft_recipe_request (upstream, 0x12)
craft_recipe_response (downstream, 0x2B) is a new packet.
advancement_progress has been renamed to select_advancement_tab I'm fairly sure we're fine renaming it, but want @barneygale to confirm. (see this revision on wiki.vg)

Otherwise, great job! Thanks for sending this in.

ocelotpotpie commented 7 years ago

@williammck Thanks for the tips!

I've updated the PR to reflect the changes you referenced.

ocelotpotpie commented 7 years ago

@williammck Are there more steps required in your processes to have this PR merged?

barneygale commented 7 years ago

Sorry for the delay - these changes look great, thanks for your work! I'm going to test tonight, and if all looks good I'll merge and release a new version to pypi.

ocelotpotpie commented 7 years ago

@barneygale No worries! Wanted to make sure I was sticking with the process(es) you're already using. Thanks!

barneygale commented 7 years ago

Sorry for the long delay on this. The examples appear to be working against 1.12.1 with this patch. Thank you very much for this!