barneygale / quarry

Python library that implements the Minecraft network protocol and data types
Other
533 stars 74 forks source link

No license specified #47

Closed smilechaser closed 5 years ago

smilechaser commented 6 years ago

This looks like a really cool project with a lot of effort invested in it. I know I would like to use it, but am always hesitant when there is no explicit license provided.

If you have no concerns about a particular license, may I suggest the MIT license? I feel this would give users/contributors the most flexibility.

Thanks!

ghost commented 6 years ago

@smilechaser there is a license - https://github.com/barneygale/quarry/blob/master/COPYING.txt

smilechaser commented 6 years ago

Ahh good to know - thanks!

It still might be a good idea to add a LICENSE.md file though:

https://help.github.com/articles/adding-a-license-to-a-repository/

Just a friendly suggestion - feel free to close this if you don't agree.

ghost commented 6 years ago

@smilechaser I'm not the maintaner nor the contributor to this repo, and about license file - it's enough to add LICENSE, not LICENSE.md :)

barneygale commented 6 years ago

GitHub say that they use a library called Licensee for detecting licenses, and this looks like it should detect COPYING.txt. I'll look into it.

ghost commented 6 years ago

@barneygale COPYING.md is not the same as COPYING.txt

barneygale commented 6 years ago

Never trust the comments.

barneygale commented 6 years ago
      PREFERRED_EXT = %w[md markdown txt].freeze
      PREFERRED_EXT_REGEX = /\.#{Regexp.union(PREFERRED_EXT)}\z/