search

barneygale / quarry

Python library that implements the Minecraft network protocol and data types
Other
533 stars 74 forks source link

Fix for #48 #49

Closed dries007 closed 5 years ago

dries007 commented 6 years ago

While I don't think reloading the image every single request is a good idea (I think it should be read on load so it's cached and won't crash if the image file doesn't exist or is deleted while the code is running), this does fix this issue and is the quickest possible fix.

Warning: I only tested this patch locally on my 3.7 install when upgrading a project to 1.13, and am making this PR with the GH online editor.

barneygale commented 5 years ago

Sorry for the long delay, and thanks for the fix. I'll look into caching the favicon.