search

barosl / homu

A bot that integrates with GitHub and your favorite continuous integration service
http://homu.io/
MIT License
661 stars 102 forks source link

Make r+ remove try bit #110

Open Manishearth opened 9 years ago

Manishearth commented 9 years ago

try followed by r+ doesn't work without a try- otherwise

r? @barosl

barosl commented 9 years ago

Hmm, the logic behind the current try handling is currently very confusing, and may require refactoring. But, AFAICT, try followed by r+ should work when the PR hits the top of the queue, because the try flag will be cleared at that time. Am I missing something?

Manishearth commented 9 years ago

I think that misses the case where new commits have been pushed since then.