Add a `linear_fake_merge` option (defaulting to True)

barosl / homu

A bot that integrates with GitHub and your favorite continuous integration service

http://homu.io/

MIT License

661 stars 102 forks source link

Add a `linear_fake_merge` option (defaulting to True) #139

Open cgwalters opened 8 years ago

cgwalters commented 8 years ago

One of my projects (projectatomic/rpm-ostree) has a protected master branch. I was rather horrified to realize that homu force-pushes to master by default. Admittedly, I understand this is the only way to make github think the PR was merged (as opposed to just closed).

But in my mind, that's a deficiency of github - it should have an API to allow us to "close merged with this commit".

Anyways, add an option so that those who prefer closing-as-unmerged over force pushing can do that today.

cgwalters commented 8 years ago

Thinking about this a bit more, one thing we can do is change the title of the PR to say [merged] foo bar baz.

cgwalters commented 8 years ago

Now updated to also retitle the commit with [merged]

ashcrow commented 8 years ago

:+1: looks good!