barryvdh / laravel-async-queue

Laravel Async Queue Driver
286 stars 76 forks source link

Going to support 5.4? #64

Closed CBox closed 7 years ago

CBox commented 7 years ago

Hey there,

Is there any plan to support 5.4?

Thanks!

barryvdh commented 7 years ago

Not actively for now, but open for PR. Whats the problem?

CBox commented 7 years ago

I'm getting: ErrorException in AsyncQueue.php line 12: Declaration of Barryvdh\Queue\AsyncQueue::pushToDatabase() should be compatible with Illuminate\Queue\DatabaseQueue::pushToDatabase($queue, $payload, $delay = 0, $attempts = 0)

Any idea?

mohank28 commented 7 years ago

Hi im getting this error and iam using Laravel 5.4.16 Using version ^0.5.0 for barryvdh/laravel-async-queue ./composer.json has been updated Loading composer repositories with package information Updating dependencies (including require-dev) Your requirements could not be resolved to an installable set of packages.

Problem 1

CBox commented 7 years ago

Change your composer: "barryvdh/laravel-async-queue": "dev-master"

But I'm still heaving the same issue :/

barryvdh commented 7 years ago

Can you try with v0.6.0?

mohank28 commented 7 years ago

Hi @barryvdh, thanks for the 5.4 support, Here is my config, 'async' => [ 'driver' => 'async', 'table' => 'jobs', 'queue' => 'default', 'expire' => 60, 'binary' => '/usr/bin/php7.0', 'binary_args' => '', ],

Still im not getting the queue process in background. Pls tell about binary args.

barryvdh commented 7 years ago

You usually don't need binary and binary_args at all. Do you have any errors in your logs?

mohank28 commented 7 years ago

Yes, here is my log, `[2017-04-04 12:55:11] local.ERROR: Symfony\Component\Debug\Exception\FatalThrowableError: Call to undefined method Illuminate\Queue\Worker::getManager() in /home/vagrant/Code/summerside/vendor/barryvdh/laravel-async-queue/src/Console/AsyncCommand.php:72 Stack trace:

0 /home/vagrant/Code/summerside/vendor/barryvdh/laravel-async-queue/src/Console/AsyncCommand.php(59): Barryvdh\Queue\Console\AsyncCommand->processJob('async', '5', Object(Illuminate\Queue\WorkerOptions))

1 [internal function]: Barryvdh\Queue\Console\AsyncCommand->fire(Object(Illuminate\Queue\WorkerOptions))

2 /home/vagrant/Code/summerside/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(29): call_user_func_array(Array, Array)

3 /home/vagrant/Code/summerside/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(87): Illuminate\Container\BoundMethod::Illuminate\Container{closure}()

4 /home/vagrant/Code/summerside/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(31): Illuminate\Container\BoundMethod::callBoundMethod(Object(Illuminate\Foundation\Application), Array, Object(Closure))

5 /home/vagrant/Code/summerside/vendor/laravel/framework/src/Illuminate/Container/Container.php(531): Illuminate\Container\BoundMethod::call(Object(Illuminate\Foundation\Application), Array, Array, NULL)

6 /home/vagrant/Code/summerside/vendor/laravel/framework/src/Illuminate/Console/Command.php(182): Illuminate\Container\Container->call(Array)

7 /home/vagrant/Code/summerside/vendor/symfony/console/Command/Command.php(265): Illuminate\Console\Command->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Illuminate\Console\OutputStyle))

8 /home/vagrant/Code/summerside/vendor/laravel/framework/src/Illuminate/Console/Command.php(167): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Illuminate\Console\OutputStyle))

9 /home/vagrant/Code/summerside/vendor/symfony/console/Application.php(826): Illuminate\Console\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))

10 /home/vagrant/Code/summerside/vendor/symfony/console/Application.php(189): Symfony\Component\Console\Application->doRunCommand(Object(Barryvdh\Queue\Console\AsyncCommand), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))

11 /home/vagrant/Code/summerside/vendor/symfony/console/Application.php(120): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))

12 /home/vagrant/Code/summerside/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php(123): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))

13 /home/vagrant/Code/summerside/artisan(35): Illuminate\Foundation\Console\Kernel->handle(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))

14 {main} `

barryvdh commented 7 years ago

Can you also update Laravel to the latest 5.4 version? (.17 I think)

mohank28 commented 7 years ago

@barryvdh Thanks! It works with Laravel 5.4.17.

CBox commented 7 years ago

@barryvdh thanks man! working for me too.