bartbutenaers / node-red-contrib-xterm

A Node-RED node terminal front-end, to execute backend CLI commands
Apache License 2.0
19 stars 3 forks source link

Check if security issues #9

Closed bartbutenaers closed 4 years ago

bartbutenaers commented 4 years ago

Check whether there might be any security issues?
This node has been designed to use the standard Node-RED communication:

But the Security section in the readme page of node-pty shows this:

All processes launched from node-pty will launch at the same permission level of the parent process. Take care particularly when using node-pty inside a server that's accessible on the internet. We recommend launching the pty inside a container to protect your host machine.

Not sure whether how big this issue is. Because there are currently other ways to execute backend commands, like e.g. the Exec and Daemon nodes ...

bartbutenaers commented 4 years ago

Julian has added his comments on Discourse. Enough for me to continue ...