bartosz-antosik / vscode-spellright

Multilingual, Offline and Lightweight Spellchecker for Visual Studio Code
Other
359 stars 36 forks source link

Since I have updated the extension today, the eye icon has disappeared. #152

Closed gusbemacbe closed 6 years ago

gusbemacbe commented 6 years ago

Hello,

In the former version, eye icon appeared normally in the bottom bar. But as you have upgraded the version today, I have updated, the eye icon has disappeared.

image

gusbemacbe commented 6 years ago

It appeared after 20 minutes. It seems to be debugging or loading bug.

As it appeared after 20 minutes, spelling checker interprets some symbols as wrong:

I also ran one command in a HTML file:

<!-- %% spellcheck-language en_GB -->
<!-- %% spellcheck-language pt_PT -->

And the eye icon appeared as red with "multi" and alerted it was an error, saying: "Spell Checking - Multiple Languages (missing: en_GB -->, pt_PT -->)".

This error also happened in any CSS, C, C++, PHP and Python files, like:

/* %% spellcheck-language en_GB */
/* %% spellcheck-language pt_PT */
bartosz-antosik commented 6 years ago

Hi! Thanks for detailed report. I think what you describe are three distinct things actually:

1) There are sometimes issues with "Insders" build (#142). Often they are not Spell Right related. I cannot reproduce the 20 minutes starting time, maybe you can see Developer Tools (Help -> Toggle Developer Tools) to see whether there is something related to Spell Right?

2) I will have a look, these may be related to the spelling back-end that you use (Hunspell, native on Linux). There was a change related to these recently (#143).

3) This is true, it may be considered a bug, but it has changed in version 2.1.32. These spellcheck-langiage in-document switches will work fine when in line comments (e.g // in c++). They fail when put in block comments as you did. I will address this shortly.

gusbemacbe commented 6 years ago

Hi,

  1. Ah, I have just started VSCode and open the HTML file, and the eye appears quickly in milliseconds because it is already cached/cookied. But I believe it is CPU/GPU problem or cache or cookie problem.
  2. And do not forget of taking all these quotation marks: https://en.wikipedia.org/wiki/Quotation_mark#Summary_table and look at the table of typography at the right: https://en.wikipedia.org/wiki/Question_mark
  3. Yes, // is supported only in C, C++ PHP and Python. And ##?
bartosz-antosik commented 6 years ago

Could you show me how it gets wrong on point 2 (quotation marks)? My instance is seem to be working ok with these. As you might have examined #143 has added these symbols.

gusbemacbe commented 6 years ago
bartosz-antosik commented 6 years ago

Also, I don't get this "C (only one letter)" situation. Could you please shed some light in this?

gusbemacbe commented 6 years ago

They are not considered errors in Brazilian Portuguese, English, French, German and Italian.

bartosz-antosik commented 6 years ago

Could I see the suggestions they get?

gusbemacbe commented 6 years ago

image image image image

gusbemacbe commented 6 years ago
gusbemacbe commented 6 years ago

Do these commands like: <!-- %% spellcheck-language en_GB --> <!-- %% spellcheck-language pt_PT --> still work in the last version?

I ran these commands in a HTML file, the eye icon got off.

bartosz-antosik commented 6 years ago

Yes, they do, just the language has to be in double quotes. Please see README or CHANGELOG.

bartosz-antosik commented 6 years ago

Regarding things combined in this issue:

1) I will not do anything about the Insiders build as a) it works in my installation of Insiders build so I am eager to speculate that it is some other extension which holds Extension Host and causes the delay you describe.

2) Punctuation symbols have been added in version 2.3.4. I will not do anything about misspelling of separate letters in some dictionaries as it turns out it is a dictionary issue. Id does not happen/happens only for selected letters in other languages (dictionaries):

image

image

3) In-Document command: spellcheck-language has been changed to have the parameter in double quotes to allow for dictionaries which contain space in filenames on some platforms.