search

bartve / disconnect

An easy to use Node.js client with OAuth support to connect with the discogs.com API v2.0
MIT License
442 stars 79 forks source link

ECMAScript 6 #24

Open bartve opened 8 years ago

bartve commented 8 years ago

Research + start implementation of the most widely supported new ECMAScript 6 elements and syntax.

LostCrew commented 7 years ago

@bartve Can I open a PR that introduces a first set of ES6 features? Would you rather prefer to agree on which features we could make use of first?

bartve commented 7 years ago

Hmm, to be honest I'd rather do it myself for the learning experience. Not much time at the moment though... For me it's low prio too as ES6 will only change some syntax, not add new features to disconnect. I was thinking about looking into let, arrow functions and the new class syntax first and go from there.

LostCrew commented 7 years ago

@bartve I understand. I'd look into const, let, destructuring, spread and async/await. class also could be effortlessly introduced. Do you need any help on other aspects of the library?

bartve commented 7 years ago

Something like this https://gist.github.com/bartve/333024ae035eaf7b3d9a8478e2e10f23 is as far as I'd like to go. Some subtle scoping changes and greatly improved readability.

bartve commented 7 years ago

Anyway, there's now a new es6 branch with some big re-writes here and there. Still need to test it properly before merging it with master and release it.

LostCrew commented 7 years ago

Sweet @bartve, I will use it for https://github.com/LostCrew/rym2discogs, thanks!