base-org / op-viem

Viem extensions for the Op Stack
https://opviem.sh
MIT License
345 stars 235 forks source link

Missing event type actions #126

Open roninjin10 opened 1 year ago

roninjin10 commented 1 year ago

There is no action for getting deposits by address or getting withdrawals by address. These are utils that most folks should be using an indexer for but it's a good idea to offer an RPC only way of doing it too.

This could be an action like the current sdk:

getDepositsByAddress({
  address: Address,
  bridgeAddress: Address
  startBlock,
  endBlock
})

Alternatively we could reexport the abis for these events and document how to use them in viem. This is likely the best option because then it can be composed with all the existing viem methods like watchEvent.

The third alternative is to wrap existing viem methods


watchDepositEvents()
watchDepositEvents({bridgeAddress})
getBridgeDepositLogs({bridgeAddress, fromAddress, toAddress})
roninjin10 commented 1 year ago

Personally I like the third alternative of wrapping existing viem methods with bridge specific stuff but believe alternative 2 is the lightest lift so would start there anyways