search

basecamp / kamal

Deploy web apps anywhere.
https://kamal-deploy.org
MIT License
10.22k stars 388 forks source link

Discrepancy between docs and implementation for secrets destination file in Kamal 2 #984

Closed jeromedalbert closed 3 hours ago

jeromedalbert commented 4 hours ago

Kamal 2 docs currently mention that if you are using destinations, secrets will be read from .kamal/secrets-<DESTINATION> if it exists.[1] [2]

But the code currently reads from .kamal/secrets.<DESTINATION>:

https://github.com/basecamp/kamal/blob/8c32e6af07356031ffbad2e8eb60169904bc5e52/lib/kamal/secrets.rb#L10

So either the docs should be changed to mention .kamal/secrets.<DESTINATION> (https://github.com/basecamp/kamal-site/pull/108), or the code should read from .kamal/secrets-<DESTINATION> (https://github.com/basecamp/kamal/pull/983).

jeromedalbert commented 3 hours ago

Fixed by https://github.com/basecamp/kamal-site/pull/106.