search

baseclass / Contrib.Nuget

Extending nuget with nuget packages
MIT License
30 stars 21 forks source link

[PAKET] cannot use when sln file is not in the same directory as paket.dependencies file #40

Closed somdoron closed 6 years ago

somdoron commented 6 years ago

Paket is usually at the root git directory and sln file is usually within src directory. The way the code resolve if the project is using paket is by looking at the sln directory for paket.dependecies.

I suggest also looking for the paket.dependencies file at the top git directory (if that is possible) or at the parent directory of the sln file

romerod commented 6 years ago

Ok, we could check for the existance of the paket.references file in the project directory instead, would that work on your case?

somdoron commented 6 years ago

yes, but we also have to fix the code that checks the paket.lock:

https://github.com/baseclass/Contrib.Nuget/blob/a00863d640aa8e656e9371957bb532d7d6662080/Baseclass.Contrib.Nuget.Output/Baseclass.Contrib.Nuget.Output.Build/PaketPackageManager.cs#L40

and also here:

https://github.com/baseclass/Contrib.Nuget/blob/a00863d640aa8e656e9371957bb532d7d6662080/Baseclass.Contrib.Nuget.Output/Baseclass.Contrib.Nuget.Output.Build/PaketPackageManager.cs#L27

romerod commented 6 years ago

That one can traverse the directory tree, at that point we know that there must be one.

Are you using the package?

From: Doron Somech notifications@github.com Sent: Saturday, November 11, 2017 8:52:31 AM To: baseclass/Contrib.Nuget Cc: Daniel Romero; Comment Subject: Re: [baseclass/Contrib.Nuget] [PAKET] cannot use when sln file is not in the same directory as paket.dependencies file (#40)

yes, but we also have to fix the code that checks the paket.lock:

https://github.com/baseclass/Contrib.Nuget/blob/a00863d640aa8e656e9371957bb532d7d6662080/Baseclass.Contrib.Nuget.Output/Baseclass.Contrib.Nuget.Output.Build/PaketPackageManager.cs#L40

and also here:

https://github.com/baseclass/Contrib.Nuget/blob/a00863d640aa8e656e9371957bb532d7d6662080/Baseclass.Contrib.Nuget.Output/Baseclass.Contrib.Nuget.Output.Build/PaketPackageManager.cs#L27

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/baseclass/Contrib.Nuget/issues/40#issuecomment-343647744, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADEJ3strThE_pvfcDyFvvuWfDiwfraTcks5s1VI_gaJpZM4QaZer.

somdoron commented 6 years ago

That will work, thank you. Yes, I'm both using the library in my own package and consume it.

my package: https://www.nuget.org/packages/zen_secp256k1_linux/

I also plan to have one for windows and one for osx which copy the native library to the output directory.

I can submit the pull request later today if you want.

romerod commented 6 years ago

Happy to accept the PR

From: Doron Somech notifications@github.com Sent: Saturday, November 11, 2017 9:19:37 AM To: baseclass/Contrib.Nuget Cc: Daniel Romero; Comment Subject: Re: [baseclass/Contrib.Nuget] [PAKET] cannot use when sln file is not in the same directory as paket.dependencies file (#40)

That will work, thank you. Yes, I'm both using the library in my own package and consume it.

my package: https://www.nuget.org/packages/zen_secp256k1_linux/

I also plan to have one for windows and one for osx which copy the native library to the output directory.

I can submit the pull request later today if you want.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/baseclass/Contrib.Nuget/issues/40#issuecomment-343648883, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADEJ3vI5tBOBFyxwpttSXZ21SLTd3Q8Uks5s1ViZgaJpZM4QaZer.