search

baseprime / dynamodb

DynamoDB data mapper for Node.js
Other
296 stars 88 forks source link

Update dependencies #70

Closed line0 closed 4 years ago

line0 commented 4 years ago

This PR updates all dependencies to current packages versions and includes (only) the necessary API usage changes to keep dynamodb working. However, since dynamodb exposes Joi on its own API and Joi recently dropped support for node < ~8~10, this should be considered a breaking change.

Gets rid of all 31 vulnerabilities (8 low, 5 moderate, 16 high, 2 critical) previously reported by npm audit.

Not yet ready to merge because even though all tests succeed, I have not yet given this a real world test drive.

JacopoDaeli commented 4 years ago

Any updates on this?

line0 commented 4 years ago

@JacopoDaeli these changes have been working well in our applications for quite a few weeks now.

line0 commented 4 years ago

updated the PR with latest dependency versions, now targets node >= 10.

MickL commented 4 years ago

Should we fork instead? Seems like this is no more maintained? I would add automated testing and Typescript definitions then.

MickL commented 4 years ago

@baseprime @ryanfitz

MickL commented 4 years ago

@line0 I checked your PR, looks very good, all tests passed.

I also made a PR into your PR. Just updating the readme, gitignore and version number. :)

baseprime commented 4 years ago

@MickL This package is maintained, PRs need to include tests.

MickL commented 4 years ago

@baseprime I dont know what you mean by include tests? Doesnt circle-ci run automatically on each PR? And then it should comment the issue if the tests have run successful.

line0 commented 4 years ago

@baseprime what other tests do you need? The existing unit & integration tests pass, one test was added to validate an issue that came up and no additional functionality has been added.

baseprime commented 4 years ago

@line0 Can you run your tests and paste the results here? Tests for this PR aren't passing on CircleCI.

JacopoDaeli commented 4 years ago

@line0 I confirm. These changes working fine for me too.

JacopoDaeli commented 4 years ago

@line0 @MickL I'm currently using your fork for a project I am building and it works just fine.

MickL commented 4 years ago

@baseprime Could you please make CircleCI results public in GitHub repositories? I can not see that there are automatic tests running and which results they have. It should be added to each PR automatically by CircleCI.

If they are public everyone can see them and everyone can contribute if a test fails, not just the one who created the PR.

line0 commented 4 years ago

updated dependencies again. here's the test results:

dynamodb-tests-g7eb5434-20200921.log

baseprime commented 4 years ago

Merged latest CI config with https://github.com/line0/dynamodb/pull/4