bash-j / mikey_nodes

comfy nodes from mikey
MIT License
100 stars 15 forks source link

Lora Syntax Processor #6

Closed JHNewton closed 8 months ago

JHNewton commented 1 year ago

This particular node is rather interesting for me. Unfortunately, it seems to require a seed and there is no attachment or widget for entering a seed.

Question for you - can this node also read wildcard files and pull loras out if they are in the wildcard file? as an example: I want to create a wildcard file with various races (fantasy) and other attributes. ie -
{male|female}, , eye-color, hair-color {male|female}, , eye-color, hair-color, facial hair

You probably get the idea.

bash-j commented 1 year ago

Thank you for bringing that to my attention @JHNewton.

I have added the seed widget to the node. It's only required for the <random:0:1> syntax which you can add to the weight. e.g. <lora:lora_file:<random:0.5:1>> and it will add a random number for the lora weight.

For the wildcard you should use the wildcard and lora syntax processor node, which does support __wildcard__ syntax, and yes it should also load the lora if the line returned from the wildcard file contains lora syntax.

image

JHNewton commented 1 year ago

Cool. Thanks

On Fri, Sep 1, 2023, 23:11 bash-j @.***> wrote:

Thank you for bringing that to my attention @JHNewton https://github.com/JHNewton.

I have added the seed widget to the node. It's only required for the random:0:1 syntax which you can add to the weight. e.g.

and it will add a random number for the lora weight. For the wildcard you should use the wildcard and lora syntax processor node, which does support *wildcard* syntax, and yes it should also load the lora if the line returned from the wildcard file contains lora syntax. [image: image] — Reply to this email directly, view it on GitHub , or unsubscribe . You are receiving this because you were mentioned.Message ID: ***@***.***>
JHNewton commented 1 year ago

I take it that you don't parse YAML wildcard files.

Regards, John Newton

Fotographixs http://www.fotographixs.com Instagram https://instagram.com/john.fotographixs/ Facebook https://www.facebook.com/profile.php?id=1240206692

I don't think that I'll ever reach the stage when I will say, "This is what I believe. Finished." What I believe is alive ... and open to growth. --Madeleine L'Engle

On Sat, Sep 2, 2023 at 9:13 AM John Newton @.***> wrote:

Cool. Thanks

On Fri, Sep 1, 2023, 23:11 bash-j @.***> wrote:

Thank you for bringing that to my attention @JHNewton https://github.com/JHNewton.

I have added the seed widget to the node. It's only required for the random:0:1 syntax which you can add to the weight. e.g.

and it will add a random number for the lora weight. For the wildcard you should use the wildcard and lora syntax processor node, which does support *wildcard* syntax, and yes it should also load the lora if the line returned from the wildcard file contains lora syntax. [image: image] — Reply to this email directly, view it on GitHub , or unsubscribe . You are receiving this because you were mentioned.Message ID: ***@***.***>
bash-j commented 1 year ago

I'm not familiar with wildcard yaml files. How do they work?

JHNewton commented 1 year ago

It works! But I have no real idea w How or why. I know that Was doesn't like them. The ones I'm trying to figure out look interesting. It sort of looks like a marriage between xml and json. No tabs allowed, only spaces. Just so you know, I haven't look at any code for 20 years now. Python is completely new to me and I'm stumbling my way trying to learn it. When I retired, xml was the hot thing. So you're dealing with a 75 year old noobe.

On Sat, Sep 2, 2023, 19:10 bash-j @.***> wrote:

I'm not familiar with wildcard yaml files. How do they work?

— Reply to this email directly, view it on GitHub https://github.com/bash-j/mikey_nodes/issues/6#issuecomment-1703960819, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVZJJ4KKCBW4TIJHNVC4HALXYO4GHANCNFSM6AAAAAA4HU2K2Q . You are receiving this because you were mentioned.Message ID: @.***>

bash-j commented 1 year ago

All good :) All the wildcards I have used are just plain text files with a different prompt on each line. So curious how a yaml would improve on that.

JHNewton commented 1 year ago

Take a look at " Billions of characters" on CivitAI. I that is a pretty heavy duty. Yaml wildcard example. I'm still puzzling my way through it.

BTW, I jury rigged a solution. I'll send json when I get back on the computer

On Mon, Sep 4, 2023, 01:11 bash-j @.***> wrote:

All good :) All the wildcards I have used are just plain text files with a different prompt on each line. So curious how a yaml would improve on that.

— Reply to this email directly, view it on GitHub https://github.com/bash-j/mikey_nodes/issues/6#issuecomment-1704619733, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVZJJ4IEBAII3UI44KDJLG3XYVPGHANCNFSM6AAAAAA4HU2K2Q . You are receiving this because you were mentioned.Message ID: @.***>

JHNewton commented 1 year ago

Getting an error today after doing an update: !!! Exception during processing !!! Traceback (most recent call last): File "D:\ComfyUI_windows_portable\ComfyUI\execution.py", line 151, in recursive_execute output_data, output_ui = get_output_data(obj, input_data_all) File "D:\ComfyUI_windows_portable\ComfyUI\execution.py", line 81, in get_output_data return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True) File "D:\ComfyUI_windows_portable\ComfyUI\execution.py", line 74, in map_node_over_list results.append(getattr(obj, func)(**slice_dict(input_data_all, i))) TypeError: WildcardAndLoraSyntaxProcessor.process() got an unexpected keyword argument 'extra_pnginfo'

Regards, John Newton

Fotographixs http://www.fotographixs.com Instagram https://instagram.com/john.fotographixs/ Facebook https://www.facebook.com/profile.php?id=1240206692

I don't think that I'll ever reach the stage when I will say, "This is what I believe. Finished." What I believe is alive ... and open to growth. --Madeleine L'Engle

On Mon, Sep 4, 2023 at 11:46 AM John Newton @.***> wrote:

Take a look at " Billions of characters" on CivitAI. I that is a pretty heavy duty. Yaml wildcard example. I'm still puzzling my way through it.

BTW, I jury rigged a solution. I'll send json when I get back on the computer

On Mon, Sep 4, 2023, 01:11 bash-j @.***> wrote:

All good :) All the wildcards I have used are just plain text files with a different prompt on each line. So curious how a yaml would improve on that.

— Reply to this email directly, view it on GitHub https://github.com/bash-j/mikey_nodes/issues/6#issuecomment-1704619733, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVZJJ4IEBAII3UI44KDJLG3XYVPGHANCNFSM6AAAAAA4HU2K2Q . You are receiving this because you were mentioned.Message ID: @.***>

bash-j commented 1 year ago

Sorry about that. Can you please try updating again?