search

basho / riak-java-client

The Riak client for Java.
Apache License 2.0
267 stars 158 forks source link

Support TLS port / RIAK-2913 #694

Closed lukebakken closed 2 years ago

lukebakken commented 7 years ago

Related to basho/riak_api#119

srgg commented 7 years ago

Is there any other reason other than historical to prefer RiakSecurityDecoder usage rather then use SslHandler ?

Usage of the built-in handler will simplify our codebase as well as it also simplify further maintenance. as well as it makes our code less "promises'ious" and make it more Netty'ish. 

I could step on this and refactor our code to use it

UPD Figured out that SslHandler already used under the hood in RiakSecurityDecoder, curious if there any chance to make it more Netty'ish.

lukebakken commented 7 years ago

@srgg - that may make sense, but is outside the scope of this PR.