search

basho / riak_cs

Riak CS is simple, available cloud storage built on Riak.
http://docs.basho.com/riakcs/latest/
Apache License 2.0
568 stars 94 forks source link

Incorrect child specs for fsm sups #1066

Open seancribbs opened 9 years ago

seancribbs commented 9 years ago

These child specs should be supervisors, not workers.

Thanks @DeadZen for finding this.

kuenishi commented 9 years ago

I believe it's harmless as the child_type is used only for which_children and count_children in supervisor. c.f. https://github.com/basho/otp/blob/otp-16b02-basho/lib/stdlib/src/supervisor.erl Nonetheless, we'll care that.

DeadZen commented 9 years ago

Cool, thanks @kuenishi / @seancribbs, Yes I see these are not harmful, mostly out of the execution path, and probably would not turn up without visual examination of the code. It may help tho to keep them from becoming harmful if we mark them when one happens upon them. Btw, that was quick. So, here's another one.. #1069 :)

On Tue, Feb 3, 2015 at 4:11 PM, UENISHI Kota notifications@github.com wrote:

I believe it's harmless as the child_type is used only for which_children and count_children in supervisor. c.f. https://github.com/basho/otp/blob/otp-16b02-basho/lib/stdlib/src/supervisor.erl Nonetheless, we'll care that.

— Reply to this email directly or view it on GitHub https://github.com/basho/riak_cs/issues/1066#issuecomment-72735587.