basho / riak_cs

Riak CS is simple, available cloud storage built on Riak.
http://docs.basho.com/riakcs/latest/
Apache License 2.0
568 stars 94 forks source link

Statistics reporting issue. #690

Closed lukebakken closed 11 years ago

lukebakken commented 11 years ago

ZD issue 6110.

Retrieving usage statistics for a user reports stats in the various SystemError* elements instead of the non-error ones, even though the S3 operations completed successfully.

# s3cmd get s3://riak-cs/usage/EBCGWOHZGQL9G6DQ1_1L/abx/20130901T130000Z/20131001T192649Z

s3://riak-cs/usage/EBCGWOHZGQL9G6DQ1_1L/abx/20130901T130000Z/20131001T192649Z -> ./20131001T192649Z [1 of 1]

1492 of 1492 100% in 0s 1901.85 B/s done

# cat 20131001T192649Z

<?xml version="1.0" encoding="UTF-8"?><Usage><Access><Nodes><Node name="riak-cs@XXXXX"><Sampl e StartTime="20131001T180000Z" EndTime="20131001T190000Z"><Operation type="UsageRead"><SystemErrorBytesOut>3345</Sy stemErrorBytesOut><SystemErrorCount>5</SystemErrorCount></Operation><Operation type="KeyRead"><SystemErrorBytesOut> 77457</SystemErrorBytesOut><SystemErrorCount>3</SystemErrorCount></Operation><Operation type="BucketRead"><SystemEr rorBytesOut>905</SystemErrorBytesOut><SystemErrorCount>1</SystemErrorCount></Operation></Sample><Sample StartTime=" 20131001T160000Z" EndTime="20131001T170000Z"><Operation type="UnknownGET"><SystemErrorBytesOut>1128</SystemErrorByt esOut><SystemErrorCount>8</SystemErrorCount></Operation><Operation type="BucketReadACL"><SystemErrorBytesOut>2475</ SystemErrorBytesOut><SystemErrorCount>5</SystemErrorCount></Operation></Sample><Sample StartTime="20131001T150000Z" EndTime="20131001T160000Z"><Operation type="UsageRead"><SystemErrorBytesOut>307</SystemErrorBytesOut><SystemErrorC ount>5</SystemErrorCount></Operation><Operation type="KeyWrite"><SystemErrorBytesIn>221922</SystemErrorBytesIn><Sys temErrorCount>10</SystemErrorCount></Operation><Operation type="BucketRead"><SystemErrorBytesOut>1810</SystemErrorB ytesOut><SystemErrorCount>2</SystemErrorCount></Operation><Operation type="BucketCreate"><SystemErrorCount>1</Syste mErrorCount></Operation></Sample></Node></Nodes><Errors/></Access><Storage><Samples/><Errors/></Storage></Usage>
reiddraper commented 11 years ago

Putting this in 1.4.2 if possible. Might slip depending on complexity.

reiddraper commented 11 years ago

I've repro'd