search

basho / riak_pb

Riak Protocol Buffers Messages
Apache License 2.0
70 stars 114 forks source link

remove R15B03 from travis config #219

Closed binarytemple-external closed 7 years ago

binarytemple-external commented 7 years ago

Travis chokes on /include/riak_ts_pb.hrl when trying to compile using R15. That shit is 5 years old anyway. It's probably safe to presume that very, very few, people are doing their modern Riak development on R15 @alexmoore this should make your PR https://github.com/basho/riak_pb/pull/218 work

thumbot commented 7 years ago

Thanks @binarytemple-bet365!

Settings ```yaml --- minimum_reviewers: 2 merge: true build_steps: - make clean - make deps - make compile - make test - make xref - make dialyzer org_mode: true timeout: 1800 ```
thumbot commented 7 years ago
patch-1 95963f3 :arrow_right: develop 4541303 :white_check_mark: completed
Looks good! :+1:
:white_check_mark: MERGE

> Started at: 2017-01-05 07:55 > Duration: 1 seconds. > Result: OK > Message: Merge Success: patch-1 95963f3f15864492718211513a758badf1b00515 onto target branch: develop 45413035823273a96ab0732610f25890986da88c > Exit Code: OK > :page_facing_up:

``` Updating 4541303..95963f3 Fast-forward (no commit created; -m option ignored) .travis.yml | 1 - 1 file changed, 1 deletion(-) ``` --------------------------------------------------
:white_check_mark: MAKE_CLEAN

> Started at: 2017-01-05 07:55 > Duration: 1 seconds. > Result: OK > Message: OK > Exit Code: 0 > :page_facing_up:

``` cd /tmp/thumbs/develop.4541303.patch-1.95963f3; make clean ==> develop.4541303.patch-1.95963f3 (clean) ``` --------------------------------------------------
:white_check_mark: MAKE_DEPS

> Started at: 2017-01-05 07:55 > Duration: 2 seconds. > Result: OK > Message: OK > Exit Code: 0 > :page_facing_up:

``` cd /tmp/thumbs/develop.4541303.patch-1.95963f3; make deps ==> develop.4541303.patch-1.95963f3 (get-deps) Pulling hamcrest from {git,"https://github.com/basho/hamcrest-erlang.git", {tag,"0.3.0-basho"}} Cloning into 'hamcrest'... ==> hamcrest (get-deps) ``` --------------------------------------------------
:white_check_mark: MAKE_COMPILE

> Started at: 2017-01-05 07:55 > Duration: 4 seconds. > Result: OK > Message: OK > Exit Code: 0 > :page_facing_up:

``` cd /tmp/thumbs/develop.4541303.patch-1.95963f3; make compile ==> hamcrest (compile) Compiled src/hamcrest.erl Compiled src/hamcrest_term.erl Compiled src/hamcrest_matchers.erl ==> hamcrest (post_compile) ==> develop.4541303.patch-1.95963f3 (compile) Compiled src/riak_pb_kv_codec.erl Compiled src/riak_pb_codec.erl Compiled src/riak_pb_search_codec.erl Compiled src/riak_pb_messages.erl Compiled src/riak_pb_dt_codec.erl Compiled src/riak_dt_pb.erl Compiled src/riak_pb.erl Compiled src/riak_ttb_codec.erl Compiled src/riak_yokozuna_pb.erl Compiled src/riak_pb_ts_codec.erl Compiled src/riak_ts_pb.erl Compiled src/riak_search_pb.erl Compiled src/riak_kv_pb.erl ``` --------------------------------------------------
:white_check_mark: MAKE_TEST

> Started at: 2017-01-05 07:55 > Duration: 11 seconds. > Result: OK > Message: OK > Exit Code: 0 > :page_facing_up:

``` cd /tmp/thumbs/develop.4541303.patch-1.95963f3; make test ==> hamcrest (compile) ==> hamcrest (post_compile) ==> develop.4541303.patch-1.95963f3 (compile) ./rebar eunit skip_deps=true ==> develop.4541303.patch-1.95963f3 (eunit) Compiled src/riak_pb_kv_codec.erl Compiled src/riak_pb_codec.erl Compiled src/riak_pb_dt_codec.erl Compiled src/riak_pb_search_codec.erl Compiled src/riak_pb_messages.erl Compiled src/riak_pb.erl Compiled src/riak_dt_pb.erl Compiled src/riak_ttb_codec.erl Compiled src/riak_yokozuna_pb.erl Compiled src/riak_pb_ts_codec.erl Compiled src/riak_ts_pb.erl Compiled src/riak_search_pb.erl Compiled test/encoding_test.erl Compiled test/riak_pb_dt_codec_tests.erl Compiled src/riak_kv_pb.erl Compiled test/bucket_props_codec_eqc.erl ======================== EUnit ======================== riak_pb_kv_codec: encode_apl_ann_test (module 'riak_pb_kv_codec')...[0.002 s] ok module 'riak_ttb_codec' module 'riak_pb_codec' riak_pb_codec: record_test...[0.011 s] ok riak_pb_codec: optional_booleans_test...[0.004 s] ok riak_pb_codec: empty_atoms_test...ok riak_pb_codec: mixed_strings_test...ok [done in 0.027 s] module 'riak_pb_messages' module 'riak_dt_pb' module 'riak_pb' module 'riak_pb_ts_codec' riak_pb_ts_codec: encode_cells_test...ok riak_pb_ts_codec: encode_row_test...ok riak_pb_ts_codec: encode_rows_test...ok riak_pb_ts_codec: encode_field_type_test...ok riak_pb_ts_codec: decode_cell_test...ok riak_pb_ts_codec: decode_cells_test...ok riak_pb_ts_codec: decode_rows_test...ok [done in 0.021 s] module 'riak_search_pb' module 'riak_ts_pb' module 'riak_pb_dt_codec' module 'riak_pb_dt_codec_tests' riak_pb_dt_codec_tests: operation_type_gset_test...ok riak_pb_dt_codec_tests: decode_operation_gset_test...ok riak_pb_dt_codec_tests: decode_fetch_response_gset_test...ok riak_pb_dt_codec_tests: decode_update_response_test...ok riak_pb_dt_codec_tests: encode_fetch_response_gset_test...ok riak_pb_dt_codec_tests: encode_update_request_gset_test...ok [done in 0.018 s] [done in 0.018 s] module 'riak_kv_pb' module 'encoding_test' encoding_test:9: pb_test_ (content encode decode)...ok encoding_test:39: pb_test_ (deleted header encode decode)...ok encoding_test:59: pb_test_ (indexes encode decode)...ok encoding_test:73: pb_test_ (empty content encode decode)...ok encoding_test:85: pb_test_ (empty repeated metas are removed/ignored)...ok encoding_test:97: pb_test_ (riak_dt-dtfetchreq-encode-decode)...ok encoding_test:113: pb_test_ (msg code encode decode)...ok [done in 0.021 s] module 'riak_pb_search_codec' bucket_props_codec_eqc:36: bucket_codec_test_ (module 'bucket_props_codec_eqc').......................................................................................................(x10)....................................................................................................(x100)..................................................................................(x10)......(x1)........ Time limit reached: 4.0 seconds. OK, passed 9368 tests [4.939 s] ok module 'riak_yokozuna_pb' ======================================================= All 26 tests passed. =INFO REPORT==== 5-Jan-2017::07:55:38 === application: inets exited: killed type: temporary ``` --------------------------------------------------
:white_check_mark: MAKE_XREF

> Started at: 2017-01-05 07:55 > Duration: 2 seconds. > Result: OK > Message: OK > Exit Code: 0 > :page_facing_up:

``` cd /tmp/thumbs/develop.4541303.patch-1.95963f3; make xref ==> hamcrest (compile) ==> hamcrest (post_compile) ==> develop.4541303.patch-1.95963f3 (compile) ./rebar xref skip_deps=true ==> develop.4541303.patch-1.95963f3 (xref) ``` --------------------------------------------------
:white_check_mark: MAKE_DIALYZER

> Started at: 2017-01-05 07:55 > Duration: 123 seconds. > Result: OK > Message: OK > Exit Code: 0 > :page_facing_up:

``` cd /tmp/thumbs/develop.4541303.patch-1.95963f3; make dialyzer ==> hamcrest (compile) ==> hamcrest (post_compile) ==> develop.4541303.patch-1.95963f3 (compile) Checking whether the PLT /home/ubuntu/.combo_dialyzer_plt is up-to-date... yes done (passed successfully) yes done (passed successfully) Creating PLT .local_dialyzer_plt ... Unknown functions: application:get_env/2 erlang:get_module_info/1 erlang:get_module_info/2 erlang:is_process_alive/1 gb_sets:is_element/2 gb_sets:is_empty/1 gb_sets:is_set/1 ordsets:is_element/2 ordsets:is_set/1 ordsets:size/1 re:run/2 sets:is_element/2 sets:is_set/1 sets:size/1 string:equal/2 string:right/2 string:str/2 done in 0m0.23s done (passed successfully) ==> develop.4541303.patch-1.95963f3 (dialyzer) ``` --------------------------------------------------
:white_large_square: 0 of 2 Code reviews from organization basho
alexmoore commented 7 years ago

We've got some customers on R15 still, so going to have to close this for now. Hopefully in a few months we can revisit it though. I've got a fix for the failing build on my PR as well.