search

basho / riak_pb

Riak Protocol Buffers Messages
Apache License 2.0
70 stars 114 forks source link

Would it be possible to release new versions to hex.pm? #256

Open doublej74 opened 2 years ago

doublej74 commented 2 years ago

This makes it easier to link the latest versions in mix. The current version on hex.pm is outdated: https://hex.pm/packages/riak_pb

martinsumner commented 2 years ago

Sorry, I'm stuck with this at the moment. An issue with tagging

The latest tag appears to be a correct semantic version, with {vsn, git} used in app.src:

git describe --dirty --abbrev=7 --tags --always --first-parent

3.0.10

However when I try and ./rebar3 hex publish:

===> riak_pb.app.src : non-semantic version number "riak_kv-2.9.1" found

Even if I delete the tag locally git tag -d riak_kv-2.9.1:

===> riak_pb.app.src : non-semantic version number "riak_kv-2.9.1" found

Likewise, If I change from using git to statically adding 3.0.10 as the vsn in app.src

No matter what, it appears to keep choosing this historic, and non-semantic versioned tag.

lukebakken commented 2 years ago

Hm, sounds like I've got some tags to rename then? Maybe adding a semver-compliant tag at the same SHA as the existing ones will fix it. I'll take a look this week.

martinsumner commented 2 years ago

@lukebakken these are tags that I added over the past few years, so its' my bad. I will try your suggestion of adding semver-compliant tags at the same SHA. I have to be careful about removing old tags, because the Erlang client is now bundled into Riak, and older Riak releases point at that tag ... so I may impact an old release.

It doesn't make sense to me why rebar3 hex cares about old tags though.